Signed zig-zag codecs for variable-length ints/longs #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed zig-zag codecs for variable-length ints/longs.
aartigao
force-pushed
the
signed-zig-zag
branch
from
5ed4ba4
to
a00eadf
Compare
|
Green light to review! 🟢 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #438 this PR adds missing zig-zag codecs for signed numbers.
I've cherry-picked the commit from #438 (it's absolutely necessary). Just because I'm always uncertain about the implications on merging things, I'll leave it as a draft to avoid the merge. Once #438 is approved/merged, I'll rebase this branch with main to have a clean history.