-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Include in ssh config (#70) #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this. Comments:
_included_config_files
is a too generic function name; this is for a very specific purpose.
But further, because the function is used only from one place and is specific to that particular case, I think it should be inlined in the caller function instead of having it as a separate function in the environment.
Test cases for the test suite are needed for verifying the intended functionality.
Agree with the function name, it could be But I'm not so sure about moving that functionality inlined on If you are ok with that I could change the function name and look into the test cases. PD: thanks to you for bash-completion ;) |
Ah, I somehow missed that the includes and the function is recursive. In that case, agreed with the current approach. |
I've added a test case for the ssh_config Include functionality (fixing some bugs along the way). |
LGTM, thanks |
This patch adds support for the Include directive in ssh_config files (issue #70).
It adds the included (readable) files to the
config
variable to be later processed by the_known_hosts_real()
function.