Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status codes to the response #82

Merged
merged 3 commits into from
Feb 19, 2018

Conversation

bhavyaagg
Copy link
Contributor

Signed-off-by: Bhavya Aggarwal bhavyaaggarwal1209@gmail.com

I have added status codes to all the responses explicitly.

Signed-off-by: Bhavya Aggarwal <bhavyaaggarwal1209@gmail.com>
Signed-off-by: Bhavya Aggarwal <bhavyaaggarwal1209@gmail.com>
Signed-off-by: Bhavya Aggarwal <bhavyaaggarwal1209@gmail.com>
Copy link
Collaborator

@agentmilindu agentmilindu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@agentmilindu
Copy link
Collaborator

@psnmissaka @tharindupr Can we merge this PR?

CC @padamchopra @iammosespaulr

@bhavyaagg
Copy link
Contributor Author

Thank you for reviewing the PR @agentmilindu

Copy link
Contributor

@padamchopra padamchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work in adding specific response codes! ✨

Copy link
Collaborator

@iammosespaulr iammosespaulr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@agentmilindu agentmilindu merged commit 3fbefe9 into scorelab:master Feb 19, 2018
@bhavyaagg bhavyaagg deleted the reponse-codes branch February 19, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants