Improve Coverage

[mbillingr]

Addresses #96

[cbrnr]

LGTM. I wonder why the coverage increase isn't shown here.

[mbillingr]

It is shown when you click on "Show all checks".

[cbrnr]

Any idea why the bisection test fails?

Also, since we'll be treating the issues with parallelization in #30, maybe you should also remove the corresponding tests for now? Or is this not related?

[mbillingr]

This is not related. The problem is here:

    if trform(b) >= maxdelta and verbose:
        print('Bisection: could not find initial interval.')
        print(' ********* Delta set to zero! ************ ')
        return 0

The test checks if the function returns 0 because b is too high. This works locally because I have set verbose. On travis verbose is False so it does not return 0.

[cbrnr]

LGTM. We're almost at 90%. Can you add a test to cover the remaining 0.035%? This would be great from a psychological perspective :-).

[mbillingr]

I've meant this as a sort of open ended PR, anyway :)

[cbrnr]

We need to merge it at some point - otherwise the increased coverage remains in this branch.That's why I think 90% would be a good threshold to merge this (and continue increasing coverage in another PR later).

[mbillingr]

Right.

[mbillingr]

When writing these tests I came across a bug in CSPVARICA (we forgot to fix data orientation in one place).

Hooray for testing!

[cbrnr]

Nice! I think we can merge this now, right?