Fixes #53 fixes #43 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes to the Facebook API, the user's Facebook name and e-mail address return as undefined undefined, and undefined respectively. This PR addresses these issues, hopefully successfully fixing them. Changes made: 1. In auth.js: under Facebook, 'profileFields' was added for requesting permissions from the FB API. 2. In routes.js: 'public_profile' was added to the FB permissions scope. Although FB provides this by default to an app that was granted access by a user, it is considered best practice to declare all requested permissions. 3. In user.js: under facebook, name was changed to be before email field. Their order is the reason behind issue scotch-io#43, where email id returns as undefined.
|
Right on! I'll update the article as well to show these changes. Really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes to the Facebook API, the user's Facebook name and
e-mail address return as undefined undefined, and undefined respectively.
This PR addresses these issues, hopefully successfully fixing them.
Changes made:
permissions from the FB API.
Although FB provides this by default to an app that was granted access by
a user, it is considered best practice to declare all requested permissions.
Their order is the reason behind issue Email Id is undefined in Facebook login #43, where email id returns as undefined.