Make the build reproducible #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0] in Debian, I noticed that bitstring could not be built reproducibly. This was because the documentation used the build year in the documentation: ``` │ │ │ ├── ./usr/share/doc/python-bitstring-doc/html/bitarray.html │ │ │ │ @@ -973,11 +973,11 @@ │ │ │ │ >previous</a> |</li> │ │ │ │ <li class="nav-item nav-item-0"><a href="index.html">bitstring 4.0 documentation</a> &scott-griffiths#187;</li> │ │ │ │ <li class="nav-item nav-item-1"><a href="reference.html" >Reference</a> &scott-griffiths#187;</li> │ │ │ │ <li class="nav-item nav-item-this"><a href="">BitArray Class</a></li> │ │ │ │ </ul> │ │ │ │ </div> │ │ │ │ <div class="footer" role="contentinfo"> │ │ │ │ - &scott-griffiths#169; Copyright 2023 - 2023, Scott Griffiths. │ │ │ │ + &scott-griffiths#169; Copyright 2023 - 2024, Scott Griffiths. │ │ │ │ </div> │ │ │ │ </body> │ │ │ │ </html> ``` This patch bases this value on the SOURCE_DATE_EPOCH environment variable (if available). I originally filed this in Debian as bug #1039932 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/1039932
|
Looks fine to me. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort in Debian, I noticed that bitstring could not be built reproducibly.
This was because the documentation used the build year in the documentation:
This patch bases this value on the
SOURCE_DATE_EPOCHenvironment variable (if available). I originally filed this in Debian as bug #1039932.