Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing with golint import #10

Closed
sbrandtb opened this issue Oct 26, 2018 · 2 comments
Closed

Build failing with golint import #10

sbrandtb opened this issue Oct 26, 2018 · 2 comments

Comments

@sbrandtb
Copy link
Contributor

When building locally, I get:

 $ make
rm -rf build dist
go get golang.org/x/tools/cmd/goimports
go get github.com/golang/lint/golint
can't load package: package github.com/golang/lint/golint: code in directory /home/sebastian/go/src/github.com/golang/lint/golint expects import "golang.org/x/lint/golint"
Makefile:25: recipe for target 'tools' failed
make: *** [tools] Error 1

Short googling leads to this issue. I'm a Go beginner and cannot make heads or tails of it. Is it a version conflict?

scottjbarr added a commit that referenced this issue Oct 27, 2018
@scottjbarr
Copy link
Owner

Hi @sbrandtb

Good pickup. It looks like the official path has changed.

I've updated the tools target in the Makefile with 56eb101.

Let me know if that is good for you.

@sbrandtb
Copy link
Contributor Author

@scottjbarr Thanks, works like a charm now :)

I only had to add ~/go/bin to $PATH, but I guess that's a general Go thing and doesn't need to be mentioned in your readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants