IE7 Access is Denied error with network-path references ("//example.com/example.css") #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to see whether a stylesheet's HREF is external or not doesn't correctly identify "protocol-less" network-path references as being external. For instance, suppose I'm including some YUI CSS file from Google's CDN (and I want to fetch it using whatever protocol the page was delivered in), in my LINK tag, I would set the HREF to this: "//ajax.googleapis.com/ajax/libs/yui/2.9.0/build/base/base-min.css" Respond.js erroneously thinks this is a local file and adds it to the requestQueue. When I include this on a page in IE7, I see an "Access is denied" error on the page. I believe my updated regular expression correctly treats network-path references as external while still treating everything else the same (though I would love to have other people take a look at it and make sure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me like the regular expression on line 48 that's checking to see whether a stylesheet's href is external or not doesn't correctly identify "protocol-less" network-path references as being external. For instance, suppose I'm including some YUI CSS file from Google's CDN (and I want to fetch it using whatever protocol the page was delivered in), in my link tag, I would set the href to this: "//ajax.googleapis.com/ajax/libs/yui/2.9.0/build/base/base-min.css"
Respond.js erroneously thinks this is a local file and adds it to the requestQueue, and in IE7, I see an "Access is denied" error on the page.
I believe my updated regular expression correctly treats network-path references as external while still treating everything else the same (though I would love to have other people take a look at it and make sure).