rewrite tests to use intern #555
Conversation
patrickkettner
force-pushed
the
new_tests
branch
from
1f74ccc
to
8f5782e
Compare
|
@patrickkettner |
|
Hiya! There are other ways to get it to work, using an explicit name is sort of a I believe adding an empty dependency array to to and signature will make it On Fri, Jul 24, 2015, 4:05 AM Alexander Farkas notifications@github.com
|
We are aware of this. But we recommend to add I already checked today more of your work and found some errors and there are still some open questions. But I need to clarify some parts and need to play around first. I would suggest, that I'm trying to fix those in your forked branch so we can then pull everything in at once, if and as soon as the picturefill team decides to do so. Will start with this at Sunday/Monday. |
I can work on any issue today and saturday, so any issue you can mention before then would be appreciated. |
|
In general: I have added a new index.html into the tests director: <!DOCTYPE html>
<title>Wait a minute, I'll redirect you</title>
<meta http-equiv="refresh" content="0; url=../node_modules/intern/client.html?config=tests/intern&reporters=Html&reporters=Console">Open this in current Safari Here are things I saw (not everything an issue)
|
|
Sorry for being soo short. I have no time. Thank you!!! Really great. |
Any reason you don't want to use intern for functional tests as well? |
patrickkettner
force-pushed
the
new_tests
branch
from
8f5782e
to
5e6f7ae
Compare
|
@aFarkas I believe I updated all of your concerns |
patrickkettner
force-pushed
the
new_tests
branch
from
5e6f7ae
to
636a3ac
Compare
fixes #489...sorta
I changed the testing to use intern's QUnit's interface. It will still need to have a browserstack API (tested locally with mine, and it works).
For this to be actually useful, something akin to https://github.com/twbs/savage would need to be added for PRs. In addition, for the actual ask of #489 to be fulfilled, some kind of box that auto downloads the latest versions of browsers and runs this against them. Travis wouldn't work well for this, since its essentially linux only (there is os x support, but its invite only and really only meant for iphone apps). AppVeyor could work, since it runs on windows, but it would be an fairly non standard env. So a mac mini or custom windows hosting somewhere where chrome canary, firefox nightly, webkit nightly, and edge could be installed would probably be best (imo, at least).