Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use merge commit on bpaf master instead of deleted feature branch. #259

Closed
wants to merge 1 commit into from

Conversation

tim-seoss
Copy link
Contributor

Just a small PR to fix a build error (bpaf github have deleted the referenced feature branch, and merged to main).

@scottlamb
Copy link
Owner

Interesting. I'd assumed what I did before was stable because there was a specific commit referenced in Cargo.lock. But I can reproduce the error you're referring to...

[slamb@nuc ~/git/moonfire-nvr/server]$ cargo build
    Updating git repository `https://github.com/pacak/bpaf.git`
error: failed to get `bpaf` as a dependency of package `moonfire-nvr v0.7.5 (/home/slamb/git/moonfire-nvr/server)`

Caused by:
  failed to load source for dependency `bpaf`

Caused by:
  Unable to update https://github.com/pacak/bpaf.git?branch=exit_code#5238a606

Caused by:
  object not found - no match for id (5238a6069abca0d61cf1c000e56bbac946e7ee18); class=Odb (9); code=NotFound (-3)

...even though that commit seems to exist in the repo: pacak/bpaf@5238a60

If I switch to using rev = "5238a6069abca0d61cf1c000e56bbac946e7ee18", then it works. I guess I'll avoid using a Cargo.toml branch in the future.

Anyway, there's a new packaged release, so I'd like to use that. I've got another bpaf cleanup anyway, so I can take care of this.

scottlamb added a commit that referenced this pull request Feb 15, 2023
* use latest published crate. This is a build fix: it was broken
  when the `exit_code` branch was deleted from the `bpaf` repo, even
  though the commit still exists!
  #259

* clean up `db-dir` parsing redundancy, as suggested here:
  pacak/bpaf#165 (comment)
scottlamb added a commit that referenced this pull request Feb 15, 2023
* use latest published crate. This is a build fix: it was broken
  when the `exit_code` branch was deleted from the `bpaf` repo, even
  though the commit still exists!
  #259

* clean up `db-dir` parsing redundancy, as suggested here:
  pacak/bpaf#165 (comment)
@scottlamb
Copy link
Owner

0ffda11 should take care of this.

@scottlamb scottlamb closed this Feb 15, 2023
@tim-seoss tim-seoss deleted the bpaf_git_rev_update branch February 16, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants