Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version and all dependencies #15

Merged
merged 3 commits into from
Aug 17, 2024

Conversation

samjewell
Copy link
Collaborator

Mainly it's the Go version I want to bump. There were some security fixes:

https://go.dev/doc/devel/release#go1.22.0

@samjewell samjewell self-assigned this Aug 9, 2024
@samjewell samjewell marked this pull request as draft August 9, 2024 18:08
@samjewell
Copy link
Collaborator Author

Sorry team, I thought this was good to go, but evidently not

@scottlepp
Copy link
Owner

scottlepp commented Aug 12, 2024

@samjewell you probably need to bump the go version that is on the container that runs the build job here

Build error: requires go 1.21

Error: ../../../go/pkg/mod/github.com/apache/thrift@v0.20.0/lib/go/thrift/debug_protocol.go:24:2: package log/slog is not in GOROOT (/opt/hostedtoolcache/go/1.20.14/x64/src/log/slog)
note: imported by a module that requires go 1.21

...while you are at it. might want to bump the duckdb cli version to the latest

@samjewell samjewell marked this pull request as ready for review August 16, 2024 22:11
@samjewell
Copy link
Collaborator Author

Ok @scottlepp - this looks better now - could you take a look please? Thanks!

@scottlepp scottlepp merged commit 5059f0c into scottlepp:main Aug 17, 2024
1 check passed
@samjewell samjewell deleted the sj/bump-go-version-and-deps branch August 28, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants