Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of deprecated PortNum constructor #168

Merged

Conversation

ehamberg
Copy link

This fixes the use of the deprecated PortNum constructor that was used for showing the port number for a socket, and uses PortNumber's Show instance instead. This instance is in all versions of network scotty can use (scotty depends on >= 2.6.0.2).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.74% when pulling d3aba76 on ehamberg:fix/use-portnumber-show-instance into 9dd942f on scotty-web:master.

@ehamberg ehamberg mentioned this pull request May 12, 2015
RyanGlScott pushed a commit that referenced this pull request May 25, 2015
Fix use of deprecated `PortNum` constructor
@RyanGlScott RyanGlScott merged commit 487016b into scotty-web:master May 25, 2015
@RyanGlScott
Copy link
Contributor

Thanks! I'll take a look at #167 when I have the chance.

@ehamberg ehamberg deleted the fix/use-portnumber-show-instance branch May 26, 2015 16:36
RyanGlScott pushed a commit that referenced this pull request Sep 18, 2015
Fix use of deprecated `PortNum` constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants