Add test on handler priority #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cblp Thanks, but we can't merge code if it breaks CI. If you want to show a problem with the current implementation, could you make a dedicated subsection in the tests ("context"..) and rewrite tests such that they pass? |
|
I can't make it pass without changing main implementation. |
|
@ocramz what do you think of this implementation? |
ocramz
requested changes
Mar 9, 2024
| @@ -111,9 +111,9 @@ runAction :: MonadUnliftIO m => | |||
| -> m (Maybe Response) | |||
| runAction mh env action = do | |||
| ok <- flip runReaderT env $ runAM $ tryNext $ action `catches` concat | |||
| [ [actionErrorHandler] | |||
| [ [actionErrorHandler, statusErrorHandler, scottyExceptionHandler] | |||
There was a problem hiding this comment.
This changes the behaviour of the library, but it's not caught in the tests.
|
I'm not sure how to write such tests, I did it intuitively. I just want to see exception when it is thown from a handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.