refactor: git pre-commit cleanups #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Recommend using git config "hooksPath" over `cp` to pick up changes in hooks folder. * Use strict shell programming with -e (Abort script at first error) and -u (Treat unset variables and parameters as an error at expansion). * Only check for Shellcheck if changes to shell scripts are to be committed. * Use git diff-index as the example git pre-commit examples do. * Aggregate all changed shell scripts into one call to Shellcheck for a minor speed improvement (0.5 sec improvement for 100 shell scripts) * Use POSIX compliant call to head with -n option * Improve grep call * Do not rely on extended patterns * POSIX recommends -e with single quotes * Shellcheck does not check [t]csh scripts * Add check with Git's default whitespace checker * Apply Shellcheck to all files in repo.
scottyhardy
approved these changes
Jun 16, 2020
|
Awesome work, thanks muchly for your contribution @rchildre3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpto pick up changes inhooks folder.
-u (Treat unset variables and parameters as an error at expansion).
committed.
minor speed improvement (0.5 sec improvement for 100 shell scripts)