-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching in grid with value 0 is not working #442
Conversation
If we search using value 0 in the filter section, the search field is ignored as empty("0") will always return true
I think all the search has to be reviewed. |
I did the commit d2f71fb that actually fixes that but as @portapipe is saying this is an issue with all the numeric values that rather searching by the exact number, it is basically searching for with like that it is usually not the desirable outcome |
I think @scoumbourdis we/I can rework on the search code, so we can think to implement stuff like join/select. |
I think the best temporary solution for now is the implementation that I have in enterprise version. For example:
For example the string "=100" will search only for 100 and NOT 1100,21002... e.t.c. This will be really useful for dates as well. I have to be honest, I don't have too much time to spend on this so I think for now it is a good solution. What do you think? P.S. Still struggling to find time for the join, select implementation :) |
I was thinking about making some little changes like use “fore%” to create a ‘LIKE “fore%” ‘ to search “forest” as “foreign” and so on... for numbers if you search a number you’ll search the like, but if you add =, ><.... is what you said. I don’t think this will keep lots of work, I’m having a little hard time at work but as soon as I’ll have time I can make these changes. It’s only me and my fork? BTW I think we’ll find some time for the join select with these fixes because the code is near. I mean “phisically” near. |
I will do then the fastest possible. I have to be honest. I don't know when I will find the time to do it. For transparency, I am creating a new video with title: Which PHP Framework is best for you? (2018 update). Many people are asking me about it so I thought a video answer with some presentation will be cool :) |
Please don’t put Laravel and Symfony... they’re destroying the PHP web simplicity. |
I was thinking to create first the video in youtube. I had in mind to also have a small podcast with you like this: https://www.youtube.com/watch?v=zq_2vaP_TDo&ab_channel=groceryCRUD (but with better quality now that I know how to do it) so we can discuss our opinion about them. I definitely wanted your opinion on that :) So far I have those frameworks (I am having them alphabetically ordered). These are all the frameworks that I have experience and I will create the video:
Have in mind that Grocery CRUD Enteprise ( a product that is live 1+ years now) is using mainly libraries of Zend Framework 2 and Symfony and I didn't have any big issues so far :) |
That's fine for me. |
Hey @portapipe I will keep this for the discussion that we will have in person then ;-) |
@scoumbourdis sure :) Meanwhile we're gonna check the search stuff... I'm having issues too ATM. |
Closing this pull request as this is now solved with the commit: d2f71fb |
If we search using value 0 in the filter section, the search field is ignored as
empty("0") will always return true