WIP: Add optimization that prunes nested <g>-tags #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `mergeSiblingGroupsWithCommonAttributes` and `removeNestedGroups` used the same code in different forms. Extract it into its own function. Signed-off-by: Niels Thykier <niels@thykier.net>
If someone gave it an ID and we have not stripped it, then it is probably important and can alter the output somehow if we fiddle merge it into another node (or discard the <g> node with an ID). Signed-off-by: Niels Thykier <niels@thykier.net>
|
(have seen the flake error, will look at it later) |
An optimization that prunes nested <g>-tags when they contain exactly one <g> and nothing else (except whitespace nodes). This looks a bit like `removeNestedGroups` except it only touches <g> tags without attributes (but can remove <g>-tags completely from a tree, whereas this optimization always leaves at least one <g> tag behind). Closes: scour-project#215 Signed-off-by: Niels Thykier <niels@thykier.net>
nthykier
changed the title
|
I need to follow up on something before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimization that prunes nested -tags when they contain exactly one and nothing else (except whitespace nodes). This looks a bit like
removeNestedGroupsexcept it only touches tags without attributes (but can remove -tags completely from a tree, whereas this optimization always leaves at least one tag behind).Closes: #215