Merge pull request #146 from scoutapp/only-attempt-to-connect-if-moni…

…toring-enabled

Do not preemptively try to connect if monitoring is disabled

src/Agent.php

@@ -117,7 +117,10 @@ private function warnIfConfigValueIsNotSet(string $configKey) : void
 
     private static function createConnectorFromConfig(Config $config) : SocketConnector
     {
-        return new SocketConnector($config->get(ConfigKey::CORE_AGENT_SOCKET_PATH));
+        return new SocketConnector(
+            $config->get(ConfigKey::CORE_AGENT_SOCKET_PATH),
+            $config->get(ConfigKey::MONITORING_ENABLED)
+        );
     }
 
     public static function fromConfig(Config $config, LoggerInterface $logger, ?CacheInterface $cache = null, ?Connector $connector = null) : self

src/Connector/SocketConnector.php

@@ -40,12 +40,16 @@ final class SocketConnector implements Connector
     /** @var string */
     private $socketPath;
 
-    public function __construct(string $socketPath)
+    public function __construct(string $socketPath, bool $preEmptivelyAttemptToConnect)
     {
         $this->socketPath = $socketPath;
 
         $this->socket = socket_create(AF_UNIX, SOCK_STREAM, 0);
 
+        if (! $preEmptivelyAttemptToConnect) {
+            return;
+        }
+
         // Pre-emptive attempt to connect, strictly speaking `__construct` should not have side-effects, so if this
         // fails then swallow it. The `Agent` goes on to call connect() anyway, and handles launching of the core agent.
         try {

tests/Integration/AgentTest.php

@@ -71,7 +71,9 @@ public function testLoggingIsSent() : void
             'monitor' => true,
         ]);
 
-        $connector = new MessageCapturingConnectorDelegator(new SocketConnector($config->get(ConfigKey::CORE_AGENT_SOCKET_PATH)));
+        $connector = new MessageCapturingConnectorDelegator(
+            new SocketConnector($config->get(ConfigKey::CORE_AGENT_SOCKET_PATH), true)
+        );
 
         $_SERVER['REQUEST_URI'] = '/fake-path';