PHP extension integration #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
added
enhancement
asgrim
force-pushed
the
php-ext-integration
branch
2 times, most recently
from
bb3db22
to
23df501
Compare
asgrim
force-pushed
the
php-ext-integration
branch
from
93da59f
to
adadb5a
Compare
cschneid
reviewed
Sep 5, 2019
…dle maybe/maybe not case of extension being loaded
…ossible dependencies
asgrim
force-pushed
the
php-ext-integration
branch
from
adadb5a
to
91825f3
Compare
…an slate' at the start
|
@cschneid this is ready for review now please (note: please don't squash when merging, there are some potentially useful scripts that I added and removed within this PR which may be useful to refer back to later) |
cschneid
approved these changes
Sep 9, 2019
| Assert::keyExists($extensionCall, 'function'); | ||
| Assert::keyExists($extensionCall, 'entered'); | ||
| Assert::keyExists($extensionCall, 'exited'); | ||
| Assert::keyExists($extensionCall, 'time_taken'); |
There was a problem hiding this comment.
Does php not have a builtin for has_key?
There was a problem hiding this comment.
Yes, array_key_exists serves this purpose (and is actually used by the assertion library). The assertion library just abstracts away the logical assertion into a single semantic statement, the following is more or less equivalent:
if (!isset($extensionCall['time_taken']) || !array_key_exists('time_taken', $extensionCall)) {
throw new \InvalidArgumentException('The key time_taken did not exist');
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41