Refresh excluding packages and files #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandtritsch
commented
Jul 3, 2022
| if (sys.props.get("plugin.version").exists(_.endsWith("-SNAPSHOT"))) | ||
| Seq(Resolver.sonatypeRepo("snapshots")) | ||
| else Seq.empty | ||
| } |
There was a problem hiding this comment.
Adding a test for excludedFiles.
rolandtritsch
commented
Jul 3, 2022
| if (sys.props.get("plugin.version").exists(_.endsWith("-SNAPSHOT"))) | ||
| Seq(Resolver.sonatypeRepo("snapshots")) | ||
| else Seq.empty | ||
| } |
There was a problem hiding this comment.
Adding test for excludedPackages.
rolandtritsch
commented
Jul 3, 2022
| @@ -7,4 +7,4 @@ | |||
| > coverageOff | |||
| > test | |||
| # There should be no scoverage-data directory | |||
| -$ exists target/scala-2.12/scoverage-data | |||
| -$ exists target/scala-2.13/scoverage-data | |||
There was a problem hiding this comment.
Fixing typo, Making test work (again).
rolandtritsch
commented
Jul 3, 2022
| # There should be no directory for the excluded files | ||
| #-$ exists target/scala-3.2.0-RC1/scoverage-report/two | ||
| # But right now there is, because Scala3 does not support excluding files | ||
| $ exists target/scala-3.2.0-RC1/scoverage-report/two |
There was a problem hiding this comment.
Just to show/document that excluding files (and packages) is not working right now.
Aiming to make this work (somehow).
ckipp01
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Thanks a lot for the additional tests and documentation @rolandtritsch. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ckipp01,
here is the second PR on refreshing the excluded packages and files functionality.