Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 2.13.0-RC1 support #254

Merged
merged 2 commits into from Apr 28, 2019
Merged

Add Scala 2.13.0-RC1 support #254

merged 2 commits into from Apr 28, 2019

Conversation

gslowikowski
Copy link
Member

Fixes #250

- upgrade Scala version from 2.13.0-M5 to 2.13.0-RC1 in `build.sbt` and `.travis.yml`

- upgrade scalatest version from 3.0.6-SNAP4 to 3.0.8-RC2
- upgrade stala-xml version from 1.1.1 to 1.2.0

Some fixes in tests were required:

- 's' and 'raw' string interpolators are now implemented as macros and macros are not instrumented; 's"Hello, $name"' expression was changed to explicit strings concatenation '"Hello, " + name' so the number of instrumented statements is the same in all Scala versions
see:
scala/scala@0cebcdf#diff-648e8f7f409d844c3c99b2d5a0d0dfe5R94
scala/scala#7779

- special symbol for all compilation phases was changed from "all" to "_"
see:
scala/scala@4d29431#diff-d686e8e67add4d42682f22193d20494bR1246
scala/scala#7908
There are two kinds of warnings:

1.
[warn] .../scalac-scoverage-plugin/src/test/scala/scoverage/ScoverageCompiler.scala:102:26: method assert in class SymbolTable is deprecated (since 2.12.5): consider supplying an explanatory message
[warn]   def assertNoErrors() = assert(!reporter.hasErrors)
[warn]                          ^

2.
code_snippet3799296259402470632.scala:2: warning: symbol literal is deprecated; use Symbol("boo") instead
object Bammy { def foo = 'boo }
                         ^
@gslowikowski gslowikowski merged commit 32c24fe into master Apr 28, 2019
@gslowikowski gslowikowski deleted the scala-2-13-0-RC1 branch May 21, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Scala 2.13.0-RC1 support
1 participant