Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool for extracting XSTR calls #1740

Merged
merged 1 commit into from Nov 16, 2019

Conversation

asarium
Copy link
Member

@asarium asarium commented Jun 4, 2018

This uses clangs LibTooling for parsing the FSO source files to ASTs
which can then be used for extracing the strings used in XSTR calls.
This supports both standard XSTR calls and UI_XSTR definitions and
writes the resulting information in the strings.tbl format to stdout.
It also detects duplicate translation id usages with different text
values.

The tool is entirely optional and is automatically disabled if the clang
development libraries could not be found by CMake. I only tested this
on Linux so other platforms may encounter problems.

@asarium asarium added the enhancement A new feature or upgrade of an existing feature to add additional functionality. label Jun 4, 2018
@asarium asarium force-pushed the build/clangXstrFinder branch 4 times, most recently from e2a7d99 to fb1a68b Compare June 13, 2018 09:12
Copy link
Contributor

@Goober5000 Goober5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Not sure how this PR slipped through the cracks but I'll approve it. Some conflicts will need to be fixed before merging though.

This uses clangs LibTooling for parsing the FSO source files to ASTs
which can then be used for extracing the strings used in XSTR calls.
This supports both standard XSTR calls and UI_XSTR definitions and
writes the resulting information in the strings.tbl format to stdout.
It also detects duplicate translation id usages with different text
values.
@asarium asarium merged commit 7a11e24 into scp-fs2open:master Nov 16, 2019
@asarium asarium deleted the build/clangXstrFinder branch November 16, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or upgrade of an existing feature to add additional functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants