Move the temporary grammar files into the build directory. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, maybe not. AppVeyor's 2010 seems to not have SAPI and I don't even know what the 2012's atlbase.h error is about. |
These are only used for voice recognition on Windows. In addition, the gc.exe shouldn't be needed locally since it should be included with SAPI, which Visual Studio 2010 and later should already include. I also tried to backport some of the changes from the 2013/2015 project files to the 2010/2012 project files, but lack of certain compiler flags made me tend to err on the conservative side in that regard.
MageKing17
force-pushed
the
cleanup/move-voice-recognition-grammar-files
branch
from
ed3dc4b
to
2027983
Compare
|
Trying this again; 2010 and 2012 projects still have the directory moved, but don't set FS2_SPEECH/FS2_VOICER by default. Also leaves gc.exe just so that 2010 Express (at least, I think that's what AppVeyor is using), which apparently lacks SAPI, can still compile phrases.xml. |
z64555
added
the
cleanup
|
Looks good to me, after some discussion on IRC any concerns I had were alleviated. |
chief1983
added a commit
that referenced
this pull request
Aug 21, 2015
…n-grammar-files Move the temporary grammar files into the build directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only used for voice recognition on Windows. In addition, the gc.exe shouldn't be needed locally since it should be included with SAPI, which Visual Studio 2010 and later should already include.
I also tried to backport some of the changes from the 2013/2015 project files to the 2010/2012 project files, but lack of certain compiler flags made me tend to err on the conservative side in that regard.
Obviously, this PR will be obsoleted by the move to cmake, but I figure I might as well open it anyway since I did most of the work a while ago (just did the copy/paste job on the 2010/2012 projects for this PR).