Fixes numerous SEXPs accessing the wrong nodes. #377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected SEXPs include
turret-set-target-order
,turret-set-direction-preference
,turret-set-rate-of-fire
,turret-set-optimum-range
,ship-turret-target-order
,turret-get-primary-ammo
,turret-set-primary-ammo
,turret-get-secondary-ammo
, andturret-set-secondary-ammo
.It's worth noting that while
turret-set-direction-preference
,turret-set-rate-of-fire
, andturret-set-optimum-range
were wrong, they were wrong in a way that wouldn't actually affect the outcome most of the time (thanks to theif(turret == NULL)
checks simply skipping invalid subsystem names).