refactor submodel flags and add $rotate_accel #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
added
the
models
BMagnu
requested changes
Nov 18, 2021
| } else { | ||
| sm->dumb_turn_rate = 0.0f; | ||
| sm->default_turn_rate = turn_rate; | ||
| sm->flags.set(Model::Submodel_flags::Instant_rotate_accel); |
There was a problem hiding this comment.
This should also set the Dumb_rotates flag, no?
Though it was missing before as well...
There was a problem hiding this comment.
Turns out it's not even needed (it's redundant in the one place it's used) so I removed it.
1) Changes the submodel flags to use a flagset instead of several booleans 2) Adds `rotate_accel` to allow submodel rotation acceleration to be specified Submodel acceleration can now be instant; dumb-rotating submodels always instantly accelerate (and have always done so)
Goober5000
force-pushed
the
submodel_turn_accel
branch
from
2472fc9
to
9d6eec9
Compare
BMagnu
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rotate_accelto allow submodel rotation acceleration to be specifiedSubmodel acceleration can now be instant; dumb-rotating submodels always instantly accelerate (and have always done so)