add no-disabled-self-destruct ship flag #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, ships whose weapons or engines subsystems are destroyed will self-destruct after 90 seconds if they are part of a wing (see ai_maybe_self_destruct). This adds a ship flag to prevent that from happening.
|
Can you add this to Ship_flag_names so that the alter-ship-flag SEXP can be used with it please? |
|
Seconded; also, I'm not fond of how cluttered that fred.rc diff is, but I know how much of a pain avoiding nonfunctional changes with the form editor. Otherwise, looks fine to me; add the SEXP support and it should be good. |
|
I think it's highly unlikely that anyone would ever want to use this during a mission; it's a configuration flag more than a transient flag. But okay. |
|
Merging due to review. |
Goober5000
added a commit
that referenced
this pull request
Dec 21, 2015
add no-disabled-self-destruct ship flag
|
I don't disagree with you, but adding it to the list is so cheap that there is not really much of a reason not to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, ships whose weapons or engines subsystems are destroyed will self-destruct after 90 seconds if they are part of a wing (see ai_maybe_self_destruct). This adds a ship flag to prevent that from happening.