Convert sprintf to snprintf part 1 #5704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAFernandez
added
cleanup
JohnAFernandez
force-pushed
the
Convert-to-snprintf-part-1
branch
2 times, most recently
from
ef83637
to
294770e
Compare
As sprintf is deprecated 25 files down, 140 to go
In hud.cpp and freespace.cpp
In 4 more files
in five more files
For 5 more files
And add one more conversion pointed out while checking that it would work.
JohnAFernandez
force-pushed
the
Convert-to-snprintf-part-1
branch
from
90cfdab
to
c4d8982
Compare
|
I did not see any odd text behavior when I tested this patch. |
JohnAFernandez
added
the
Waiting for Stable
Goober5000
removed
the
Waiting for Stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses a very common warning from clang when compiling FSO that sprintf is deprecated and needs to be converted to snprintf. Now, I don't think the security issues are a huge deal for us, but on the compilation output, it will print out multiple lines for each occurrence, and we use sprintf upwards of 800 times.
This pr converts about a third of them. Note that the SCP_string overload of sprintf is not affected.
In draft until I can do some basic smoke testing. The changes were not complicated, but they are extensive.