Allow player-specific options even when using In-Game Options #6045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the methods to set the serialized values for options into OptionsManager for more global use. Then it removes the check for
Using_in_game_options
from csg.cpp and plr.cpp and instead always loads the player or campaign options and then runs those OptionsManager methods to make sure the serialized values are kept in sync for the UI.I know @notimaginative was concerned about multi options, but the only one I could definitively find that's saved to the player file was the Local Broadcast setting. Let me know if I missed one, though, and I can add it here.