Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WJ-1074] Remove [[css]] alias #1178

Merged
merged 5 commits into from
Sep 2, 2022
Merged

[WJ-1074] Remove [[css]] alias #1178

merged 5 commits into from
Sep 2, 2022

Conversation

emmiegit
Copy link
Member

@emmiegit emmiegit commented Sep 2, 2022

It was a dumb thing to add in the first place, and since it doesn't already exist in Wikidot we can safely remove it without any issue.

@emmiegit emmiegit self-assigned this Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1178 (2f5fbea) into develop (f907fac) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1178      +/-   ##
===========================================
- Coverage    36.55%   36.51%   -0.04%     
===========================================
  Files          432      431       -1     
  Lines        22207    22198       -9     
  Branches       193      193              
===========================================
- Hits          8117     8106      -11     
- Misses       14087    14089       +2     
  Partials         3        3              
Flag Coverage Δ *Carryforward flag
deepwell 7.54% <ø> (ø) Carriedforward from f907fac
ftml 80.42% <ø> (-0.06%) ⬇️
web 20.08% <ø> (ø) Carriedforward from f907fac

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
ftml/src/parsing/rule/impls/block/blocks/mod.rs 100.00% <ø> (ø)
ftml/src/parsing/rule/impls/block/mapping.rs 100.00% <ø> (ø)
ftml/src/lib.rs 12.50% <0.00%> (-25.00%) ⬇️

@emmiegit
Copy link
Member Author

emmiegit commented Sep 2, 2022

thanks @Yossipossi1

@emmiegit emmiegit merged commit deaabf8 into develop Sep 2, 2022
@emmiegit emmiegit deleted the WJ-1074-css branch September 2, 2022 06:21
Zokhoi added a commit to Zokhoi/vscode-ftml that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants