Fix #67

CHANGES.md

@@ -13,6 +13,9 @@ Note that the top-most release is changes in the unreleased master branch on Git
 ### Added
 - Allow reading private raw schemas directly from bitbucket, #58
 
+### Fixed
+- Failing `Compare Prices For Same Urls` when url is `nan`, #67
+
 
 ## [0.3.1] (2019-04-12)
 

src/arche/rules/price.py

@@ -89,6 +89,9 @@ def compare_prices_for_same_urls(
     url_field = url_field[0]
     price_field = tagged_fields.get("product_price_field")
 
+    source_df = source_df.dropna(subset=[url_field])
+    target_df = target_df.dropna(subset=[url_field])
+
     same_urls = source_df[(source_df[url_field].isin(target_df[url_field].values))][
         url_field
     ]

tests/rules/test_price.py

@@ -1,6 +1,7 @@
 import arche.rules.price as p
 from arche.rules.result import Level
 from conftest import create_result
+import numpy as np
 import pandas as pd
 import pytest
 
@@ -81,8 +82,16 @@ def test_compare_was_now(
 
 compare_prices_inputs = [
     (
-        {"_key": ["1", "0"], "price": [1, "2"], "url": ["http://1", "http://2"]},
-        {"_key": ["0", "1"], "price": [1.15, "2.3"], "url": ["http://1", "http://2"]},
+        {
+            "_key": ["1", "0", "2"],
+            "price": [1, "2", 5],
+            "url": ["http://1", "http://2", np.nan],
+        },
+        {
+            "_key": ["0", "1", "2"],
+            "price": [1.15, "2.3", 6],
+            "url": ["http://1", "http://2", np.nan],
+        },
         {"product_price_field": ["price"], "product_url_field": ["url"]},
         {
             Level.INFO: [