Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validator to func #107

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Refactor validator to func #107

merged 1 commit into from
Jun 12, 2019

Conversation

manycoding
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #107 into _key will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             _key     #107      +/-   ##
==========================================
+ Coverage   79.07%   79.08%   +<.01%     
==========================================
  Files          23       22       -1     
  Lines        1606     1597       -9     
  Branches      278      277       -1     
==========================================
- Hits         1270     1263       -7     
+ Misses        290      289       -1     
+ Partials       46       45       -1
Impacted Files Coverage Δ
src/arche/rules/json_schema.py 100% <100%> (ø) ⬆️
src/arche/tools/schema.py 88.17% <100%> (+10.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e581d16...de6ffd7. Read the comment docs.

Copy link
Member

@ivankivanov ivankivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this refactoring?

@manycoding
Copy link
Contributor Author

@ivankivanov As always, code readability. If I see something which can be written simpler I rewrite it, and by doing this I keep the code up-to-date.

@manycoding manycoding merged commit f52bca1 into _key Jun 12, 2019
@manycoding manycoding deleted the refactor_schema_val branch June 12, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants