Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for negative timestamp #1060

Merged
merged 5 commits into from Jun 17, 2022

Conversation

gutsytechster
Copy link
Collaborator

This closes #546

@gutsytechster gutsytechster marked this pull request as draft June 6, 2022 07:02
@ghost ghost marked this pull request as ready for review June 11, 2022 14:48
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1060 (d55b383) into master (89b7fda) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         234      234           
  Lines        2694     2701    +7     
=======================================
+ Hits         2648     2655    +7     
  Misses         46       46           
Impacted Files Coverage Δ
dateparser/conf.py 100.00% <ø> (ø)
dateparser/date.py 99.26% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b7fda...d55b383. Read the comment docs.

@ghost ghost changed the title [WIP] add support for negative timestamp Add support for negative timestamp Jun 12, 2022
@ghost ghost requested review from noviluni and Gallaecio June 12, 2022 13:05
dateparser/date.py Outdated Show resolved Hide resolved
docs/settings.rst Outdated Show resolved Hide resolved
tests/test_date.py Outdated Show resolved Hide resolved
* (date.py): only matches positive timestamp when given, not the default.
* (test_date.py): replace ``negative_allowed`` with ``negative`` to avoid any
  assumption that both postive and negative are parsed.
* (settings.rst): improve doc statement for ``negative-timestamp`` parser.
@ghost ghost requested a review from Gallaecio June 16, 2022 13:43
@Gallaecio Gallaecio merged commit a7ca7a5 into scrapinghub:master Jun 17, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp in milliseconds with minus (-) - parsing failes/returns None
2 participants