Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace datetime.utcnow #1179

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Replace datetime.utcnow #1179

merged 2 commits into from
Aug 21, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Aug 20, 2023

Starting with Python 3.12 datetime.utcnow will be deprecated.
https://docs.python.org/3.12/library/datetime.html#datetime.datetime.utcnow

@Gallaecio
Copy link
Member

Could you run pre-commit on your changes?

pre-commit run --all

@Gallaecio Gallaecio merged commit 725ccc0 into scrapinghub:master Aug 21, 2023
9 checks passed
@Gallaecio
Copy link
Member

Thanks!

@cdce8p cdce8p deleted the replace-utcnow branch August 21, 2023 14:56
@wimglenn
Copy link

wimglenn commented Oct 4, 2023

@Gallaecio Can you get this change released on PyPI, please?

@zerocewl
Copy link

zerocewl commented Oct 6, 2023

+1 a new release would be nice to work with python3.12

@Gallaecio
Copy link
Member

1.2.0 is out now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants