Update jsonld.py, fallback to strict=False if err #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extruct on this: https://www.allsaints.com/women/leather/allsaints-hawley-oversized-she-wl229m/ results in: ValueError: Invalid control character at: line 7 column 330 (char 529) without strict=False
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 85.14% 85.14%
=======================================
Files 7 7
Lines 303 303
Branches 53 53
=======================================
Hits 258 258
Misses 43 43
Partials 2 2
Continue to review full report at Codecov.
|
|
@origliante , looks same in intent as #57 . |
|
Yes does the same thing |
|
Sorry, I'll have to close this PR as the issue was ultimately fixed in #85, sorry for letting this PR slip through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extruct on this:
https://www.allsaints.com/women/leather/allsaints-hawley-oversized-she-wl229m/
results in:
ValueError: Invalid control character at: line 7 column 330 (char 529)
without strict=False