Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address lacking importlib metadata in Python ≤ 3.9 #442

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Jan 22, 2024

Fixes #441.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8d471c) 89.44% compared to head (fb8aff1) 89.44%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          34       34           
  Lines        2407     2407           
=======================================
  Hits         2153     2153           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio
Copy link
Member Author

The CI thing is a bit dirty, but in addition to checking for a regression on this specific issue, it also showed that we had an undeclared dependency on setuptools that would be an issue in Python 3.12.

@Gallaecio Gallaecio marked this pull request as ready for review January 22, 2024 11:43
@Gallaecio Gallaecio merged commit 10f8b0c into scrapinghub:master Jan 23, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'PathDistribution' object has no attribute 'name'
3 participants