Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hardcoding the default Docker version #445

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Gallaecio
Copy link
Member

Fixes #444

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bc420e) 89.44% compared to head (e8b2f9a) 89.44%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   89.44%   89.44%   -0.01%     
==========================================
  Files          34       34              
  Lines        2407     2406       -1     
==========================================
- Hits         2153     2152       -1     
  Misses        254      254              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio Gallaecio marked this pull request as draft February 8, 2024 12:06
@Gallaecio
Copy link
Member Author

I’ve reproduced the original issue after upgrading my Docker version to 25+, and confirmed the fix.

Need to look into those unrelated CI issues, though.

@Gallaecio Gallaecio mentioned this pull request Feb 8, 2024
1 task
@Gallaecio Gallaecio closed this Feb 8, 2024
@Gallaecio Gallaecio reopened this Feb 8, 2024
@Gallaecio Gallaecio marked this pull request as ready for review February 8, 2024 13:51
@Gallaecio Gallaecio merged commit 1705d83 into scrapinghub:master Feb 8, 2024
49 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected error connecting to Docker daemon's host. (minimum version of 1.24 needed)
2 participants