Added MonitorRunner exceptions

spidermon/exceptions.py

@@ -1,16 +1,16 @@
-class SpiderMonException(Exception):
+class SpidermonException(Exception):
     pass
 
 
-class InvalidStatsOperation(SpiderMonException):
+class InvalidStatsOperation(SpidermonException):
     pass
 
 
-class NotAllowedMethod(SpiderMonException):
+class NotAllowedMethod(SpidermonException):
     pass
 
 
-class InvalidMonitor(SpiderMonException):
+class InvalidMonitor(SpidermonException):
     pass
 
 
@@ -26,9 +26,13 @@ class InvalidMonitorTuple(InvalidMonitor):
     pass
 
 
-class InvalidExpression(SpiderMonException):
+class InvalidExpression(SpidermonException):
     pass
 
 
-class SkipAction(SpiderMonException):
+class InvalidResult(SpidermonException):
+    pass
+
+
+class SkipAction(SpidermonException):
     pass

spidermon/runners.py

@@ -1,8 +1,9 @@
 import sys
 
-from core.suites import MonitorSuite
+from spidermon.core.suites import MonitorSuite
 from spidermon.results.monitor import MonitorResult
 from spidermon.results.text import TextMonitorResult
+from spidermon.exceptions import InvalidMonitor, InvalidResult
 
 
 class MonitorRunner(object):
@@ -12,12 +13,12 @@ def __init__(self):
 
     def run(self, suite, data=None):
         if not isinstance(suite, MonitorSuite):
-            raise Exception('Not valid')  # TODO: Add custom exception
+            raise InvalidMonitor('Runners must receive a MonitorSuite instance')
         self.suite = suite
         self.suite.init_data(**(data or {}))
         self.result = self.create_result()
         if not isinstance(self.result, MonitorResult):
-            raise Exception('Not valid')  # TODO: Add custom exception
+            raise InvalidResult('Runners must use a MonitorResult instance')
         return self.run_suite()
 
     def run_suite(self):

to-do.txt

@@ -6,7 +6,7 @@ FEATURES
 [X] Descriptions
 [X] Levels
 [X] Ordering
-[ ] Monitor runner exceptions
+[X] Monitor runner exceptions
 [X] Actions
 [X] Suite actions hooks
 [X] Results