New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing guidelines to include pre-commit install #392
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 76 76
Lines 3193 3193
Branches 378 378
=======================================
Hits 2440 2440
Misses 683 683
Partials 70 70 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
itemadapter | ||
pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how requirements.txt are organized, but probably it'd be better to make an explicit requirement-dev.txt file, as not all of these requirements are needed to run spidermon.
Also, it seems some of the requirements which are here are not in setup.py, e.g. itemadapter is not in setup.py install_requires (it's in test_requires for some reason).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the package requirements are weirdly structured, we could open a new issue to fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; we don't need to fix it in this PR.
Not having itemadapter in install_requires looks like a separate issue, I think it's a bug (no need to fix it in this PR either).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.