Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kwargs on Slack API. #397

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

mrwbarg
Copy link
Contributor

@mrwbarg mrwbarg commented Apr 24, 2023

Closes #293.

Allows keyword args to be passed to the slack API.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.74 🎉

Comparison is base (e697dbe) 76.37% compared to head (36c26c1) 77.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   76.37%   77.12%   +0.74%     
==========================================
  Files          73       73              
  Lines        3103     3104       +1     
  Branches      518      518              
==========================================
+ Hits         2370     2394      +24     
+ Misses        663      636      -27     
- Partials       70       74       +4     
Impacted Files Coverage Δ
spidermon/contrib/actions/slack/__init__.py 77.19% <100.00%> (+20.55%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VMRuiz VMRuiz merged commit 8251a0f into scrapinghub:master Jul 4, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pass extra optional arguments to Slack API
3 participants