Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spidermon] Fix subtract offset-naive and offset-aware #439

Merged
merged 2 commits into from
Apr 15, 2024
Merged

[spidermon] Fix subtract offset-naive and offset-aware #439

merged 2 commits into from
Apr 15, 2024

Conversation

adnan-awan
Copy link
Contributor

@adnan-awan adnan-awan commented Mar 31, 2024 •
edited by Gallaecio
Loading

  • Add utc_now_with_timezone method in base monitor class
  • Modify PeriodicExecutionTimeMonitor with the above method usage

Fixes #438

@adnan-awan
[spidermon] Fix subtract offset-naive and offset-aware
7fd1e40 
- Add utc_now_with_timezone method in base monitor class
- Modify PeriodicExecutionTimeMonitor with the above method usage
- #438
@adnan-awan
[spidermon] Fix subtract offset-naive and offset-aware
ac2f706 
- Add alternate logic to update timezone to avoid using zoneinfo or pytz
- #438
@codecov Codecov
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.37%. Comparing base (049cb00) to head (ac2f706).

Files Patch % Lines
spidermon/contrib/scrapy/monitors/monitors.py 33.33% 1 Missing and 1 partial ⚠️
spidermon/core/monitors.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   79.43%   79.37%   -0.07%     
==========================================
  Files          76       76              
  Lines        3229     3234       +5     
  Branches      536      537       +1     
==========================================
+ Hits         2565     2567       +2     
- Misses        593      595       +2     
- Partials       71       72       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gallaecio Gallaecio merged commit 1b2432b into master Apr 15, 2024
5 of 7 checks passed
This was referenced Apr 17, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: can't subtract offset-naive and offset-aware datetimes
3 participants
@adnan-awan @wRAR @Gallaecio