Merge pull request #291 from scrapinghub/notebook-tests

TST basic tests for splash.kernel

.travis.yml

@@ -18,7 +18,7 @@ virtualenv:
 before_install:
     - sudo apt-get install python-twisted python-qt4 lua5.2-dev zlib1g-dev python-imaging
     - pip install -U qt4reactor psutil requests jsonschema strict-rfc3339 xvfbwrapper pytest funcparserlib pytest-cov codecov
-    - "if [[ $SYSTEM_PACKAGES == 'false' ]]; then pip install -UI Pillow twisted service_identity lupa; fi"
+    - "if [[ $SYSTEM_PACKAGES == 'false' ]]; then pip install -UI Pillow twisted service_identity lupa jupyter_kernel_test nose ipython[notebook]; fi"
 
 install:
     - python setup.py install

requirements.txt

@@ -19,3 +19,6 @@ requests >= 1.0
 jsonschema >= 2.0
 strict-rfc3339
 pytest-cov
+jupyter_kernel_test
+nose
+ipython[notebook]

splash/kernel/kernel.py

@@ -110,7 +110,8 @@ class SplashKernel(Kernel):
             "name": "text/x-lua",
         },
         'file_extension': '.lua',
-        'pygments_lexer': 'lua'
+        'pygments_lexer': 'lua',
+        'version': get_version(),
     }
     banner = "Splash kernel - write browser automation scripts interactively"
     help_links = [

splash/tests/test_jupyter.py

@@ -0,0 +1,54 @@
+# -*- coding: utf-8 -*-
+from __future__ import absolute_import
+
+import pytest
+jupyter_kernel_test = pytest.importorskip("jupyter_kernel_test")
+lupa = pytest.importorskip("lupa")
+
+
+class SplashKernelTest(jupyter_kernel_test.KernelTests):
+
+    @classmethod
+    def setUpClass(cls):
+        # XXX: this installs kernel spec to global user environment,
+        # not to a virtualenv.
+        from splash.kernel import kernel
+        kernel.install()
+
+        super(SplashKernelTest, cls).setUpClass()
+
+    # The name identifying an installed kernel to run the tests against
+    kernel_name = "splash"
+
+    # language_info.name in a kernel_info_reply should match this
+    language_name = "Splash"
+
+    # Optional --------------------------------------
+    # Code in the kernel's language to write "hello, world" to stdout
+    # code_hello_world = "print 'hello, world'"
+
+    # Tab completions: in each dictionary, text is the input, which it will
+    # try to complete from the end of. matches is the collection of results
+    # it should expect.
+    completion_samples = [
+        {
+            'text': 'spl',
+            'matches': {'splash'},
+        },
+        {
+            'text': 'splash:eva',
+            'matches': {'evaljs'},
+        },
+        {
+            'text': 'splash.ar',
+            'matches': {'args'},
+        },
+    ]
+
+    # Code completeness: samples grouped by expected result
+    # complete_code_samples = ['x=2']
+    # incomplete_code_samples = ['function foo(', '"""in a string']
+    # invalid_code_samples = ['x=2a']
+
+    # # Pager: code that should display something (anything) in the pager
+    # code_page_something = "help('foldl')"