Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.7.0 release #61

Merged
merged 4 commits into from Dec 9, 2022
Merged

Prepare for 0.7.0 release #61

merged 4 commits into from Dec 9, 2022

Conversation

BurnzZ
Copy link
Member

@BurnzZ BurnzZ commented Dec 9, 2022

PRs

Checklist

  • Update release date in CHANGES.rst
  • Tag 0.7.0 after merging

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #61 (152a8f0) into main (79cc82b) will decrease coverage by 2.52%.
The diff coverage is n/a.

❗ Current head 152a8f0 differs from pull request most recent head b5cfb5f. Consider uploading reports for the commit b5cfb5f to get more accurate results

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   99.48%   96.96%   -2.53%     
==========================================
  Files           6        7       +1     
  Lines         388      395       +7     
==========================================
- Hits          386      383       -3     
- Misses          2       12      +10     
Impacted Files Coverage Δ
scrapy_zyte_api/responses.py 92.06% <0.00%> (-7.94%) ⬇️
scrapy_zyte_api/_request_fingerprinter.py 89.47% <0.00%> (-7.90%) ⬇️
scrapy_zyte_api/__init__.py 71.42% <0.00%> (ø)

CHANGES.rst Outdated

* It now supports Scrapy 2.7's new ``REQUEST_FINGERPRINTER_CLASS`` which ensures
that Zyte API requests are properly fingerprinted. This addresses the issue
where Scrapy marks POST requests as duplicate if it points to the same URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"if they point" maybe?

@@ -28,43 +28,43 @@ deps =


# Earliest supported Scrapy version.
[testenv:pinned-scrapy-2.0]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new update on tox >= 4.0 had a lot of backward incompatible changes.

It's now strict on the testenv:<env_name> format which renders this old line to have this error:

pinned-26-scrapy: failed with env name pinned-scrapy-2.0 conflicting with base python python3.7
pinned-scrapy-2.0: FAIL code 1 (0.01 seconds)
evaluation failed :( (1.24 seconds)

Setting ignore_basepython_conflict=True is supposed to fix this but it doesn't work. Seems like they're still releasing a lot of regression fixes after the 4.0 release.

They're also quite aggressive on the name inference. If they see any two digits in the env name, they'd treat it as a Python version. So other workarounds like 20, 2-0, etc doesn't work.

CHANGES.rst Outdated Show resolved Hide resolved
@BurnzZ BurnzZ merged commit 17e6dff into main Dec 9, 2022
@BurnzZ BurnzZ deleted the release-0.7.0 branch December 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants