Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% Coverage #15

Merged
merged 1 commit into from
Aug 14, 2015
Merged

100% Coverage #15

merged 1 commit into from
Aug 14, 2015

Conversation

dangra
Copy link
Member

@dangra dangra commented Aug 14, 2015

No description provided.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #15 into master will increase coverage by +6.57% as of fa71f23

@@            master     #15   diff @@
======================================
  Files            4       4       
  Stmts          198     194     -4
  Branches        31      28     -3
  Methods          0       0       
======================================
+ Hit            185     194     +9
+ Partial          4       0     -4
+ Missed           9       0     -9

Review entire Coverage Diff as of fa71f23

Powered by Codecov. Updated on successful CI builds.

@@ -158,8 +164,6 @@ def extract(self):
return six.text_type(self.root)

def register_namespace(self, prefix, uri):
if self.namespaces is None:
self.namespaces = {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how this self.namespaces can be None so I just removed those lines

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

kmike added a commit that referenced this pull request Aug 14, 2015
@kmike kmike merged commit a6a97b4 into master Aug 14, 2015
@dangra dangra deleted the cover100 branch August 14, 2015 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants