CI fixes, drop Python 3.4 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually I have no idea why Sphinx was so smart, and treated 'iterator' as a type which must exist.
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 5 5
Lines 296 398 +102
Branches 52 81 +29
==========================================
+ Hits 296 398 +102
Continue to review full report at Codecov.
|
Gallaecio
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not dropping Python 2.7 yet. If we are to support Scrapy 1.8, it could be nice to have parsel working in Pyhton 2.7 for some time.