-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Scan callbacks/errbacks for return statements with values different t…
…han None
- Loading branch information
Showing
6 changed files
with
218 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
tests/test_utils_misc/test_return_with_argument_inside_generator.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import unittest | ||
|
||
from scrapy.utils.misc import is_generator_with_return_value | ||
|
||
|
||
class UtilsMiscPy3TestCase(unittest.TestCase): | ||
|
||
def test_generators_with_return_statements(self): | ||
""" | ||
'return with argument inside generator' is a SyntaxError before Python 3.3 | ||
""" | ||
def f(): | ||
yield 1 | ||
return 2 | ||
|
||
def g(): | ||
yield 1 | ||
return 'asdf' | ||
|
||
def h(): | ||
yield 1 | ||
return None | ||
|
||
def i(): | ||
yield 1 | ||
return | ||
|
||
def j(): | ||
yield 1 | ||
|
||
def k(): | ||
yield 1 | ||
yield from g() | ||
|
||
assert is_generator_with_return_value(f) | ||
assert is_generator_with_return_value(g) | ||
assert not is_generator_with_return_value(h) | ||
assert not is_generator_with_return_value(i) | ||
assert not is_generator_with_return_value(j) | ||
assert not is_generator_with_return_value(k) # not inspecting recursively | ||
|
||
|
||
if __name__ == '__main__': | ||
unittest.main() |