-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some redirection links in documentation #1041
Conversation
Looks good, +1 to merge. |
I don't understand why this build fails, it doesn't even touch the code. |
@eliasdorneles it failed because of #1034 |
LGTM too, but I'd also add the script because we'll surely need it again. @dufferzafar can you add the |
@curita Will do that today. If there's anything else you need from the script, please let me know. |
what about adding a sub-command to documentation Makefile ( |
@pablohoffman: @dufferzafar's script uses Could be something like: linkfix: linkcheck
$(PYTHON) utils/linkfix.py
@echo "Fixing redirecting links in docs has finished, check all replacements before committing them" |
@curita that sounds good, can you add and merge? |
Merged in e17f97e |
This fixes #606.
I wrote this python script to fix the docs. It uses the linkcheck output to work.
Most of the links have been fixed but in the docs/news.rst file all github issues are referred using
issue_role
, even pull requests.Like this line refers to issue 693. But 693 is actually a pull request!
Should I create a new role for pulls (in docs/_ext/scrapydocs.py) to fix them as well?