Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom "CsvItemExporter" doesn't support 'from_settings' ? #1507

Closed
jschilling1 opened this issue Sep 23, 2015 · 1 comment
Closed

custom "CsvItemExporter" doesn't support 'from_settings' ? #1507

jschilling1 opened this issue Sep 23, 2015 · 1 comment
Milestone

Comments

@jschilling1
Copy link

I used to access settings in my custom exporter using "from scrapy.conf import settings" which is now depreciated. 'from_settings' and 'from_crawler' don't work there what should i do?

class CustomCsvItemExporter(CsvItemExporter):
    def __init__(self, *args, **kwargs):
        super(CustomCsvItemExporter, self).__init__(*args, **kwargs)
    @classmethod
    def from_settings(cls, settings):
        print ('from_settings ran')
        return cls(settings)
@kmike
Copy link
Member

kmike commented Jul 25, 2018

Fixed by #3348.

@kmike kmike closed this as completed Jul 25, 2018
@kmike kmike added this to the v1.6 milestone Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants