Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image pipeline should allow to decide whether to auto-convert to jpg or not #1705

Open
ddebernardy opened this issue Jan 21, 2016 · 4 comments
Labels

Comments

@ddebernardy
Copy link

Not 100% it's accurate, but the issue got reported here:

https://news.ycombinator.com/item?id=10941213

Image pipeline converts to jpg automatically. Cannot be disabled without writing all the image code yourself

@nramirezuy
Copy link
Contributor

I guess we refer to this line

@nramirezuy
Copy link
Contributor

@dangra I set this to discuss because I'm not sure if there is any valid reason to force 'JPEG'.

@redapple
Copy link
Contributor

something along thoses lines was proposed in #250
but there was no followup since

@redapple redapple added this to the v1.2 milestone Jan 29, 2016
@redapple redapple modified the milestones: v2.0, v1.2 Jul 22, 2016
@djunzu
Copy link
Contributor

djunzu commented Jul 23, 2016

One way to disable auto-convert to .jpg is to use FilesPipeline. The only drawback is that another features from ImagesPipeline can't be used with this approach.

It makes sense that someone may want to use the features provided by ImagesPipeline but not auto-convert. I think a good solution that maintains backward compatibility is to provide a IMAGES_CONVERT_TO option that defaults to JPG and accepts NONE. And it could also allows to convert to another formats...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants