[MRG+1] tests+doc for subdomains in offsite middleware #1721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While explaining to a colleague how to restrict crawls to a specific vhost by specifying a subdomain
I noticed that the documentation doesn't demonstrate the subdomain behaviour clearly.
I then tried to point to the tests but they also lacked such an example.
As a test case it's redundant because the regex is actually tested on the TLD
so you may want me to amend the commit first.
I'd only consider it for the future possibility that someone tries to refactor the offsite middelware
and accidentally treats the top level and second level domains as a special case.