[MRG+1] Check that spidercls arguments in scrapy.crawler classes are not spid… #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll review the failing test next week, it probably needs updated expectations. |
|
+1 to make this change after fixing tests. It seems that the change allowed to find a bug in Scrapy testing suite. |
Gallaecio
force-pushed
the
spidercls-check
branch
from
3d4d67a
to
93dc247
Compare
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
==========================================
+ Coverage 84.5% 84.53% +0.02%
==========================================
Files 167 167
Lines 9406 9413 +7
Branches 1397 1400 +3
==========================================
+ Hits 7949 7957 +8
Misses 1199 1199
+ Partials 258 257 -1
|
|
Oh, right, I should cover the checks with automated tests. |
Gallaecio
force-pushed
the
spidercls-check
branch
from
93dc247
to
03e61b9
Compare
kmike
changed the title
|
Perfect, thanks @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er objects
I think this is a better approach to fix #2283. Instead of trying to make the documentation more obvious, have the code fail gracefully with a useful error message.