python3: scrapy.__version__, NoneType, urlparse_monkeypatches #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,8 @@ | |||
| from __future__ import print_function | |||
| import pkgutil | |||
| __version__ = pkgutil.get_data(__package__, 'VERSION').strip() | |||
| if not isinstance(__version__, str): | |||
There was a problem hiding this comment.
Usually when string must be a bytestring in 2.x and unicode string in 3.x it is easier to write __version__ = str(pkgutil.get_data(__package__, 'VERSION').strip())
There was a problem hiding this comment.
>>> str(b'1.2.3')
"b'1.2.3'"
kmike
added a commit
that referenced
this pull request
Nov 4, 2013
PY3: scrapy.__version__, NoneType, urlparse_monkeypatches
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 compatibility changes:
__version__will bestrin both 2 and 3. Necessary because pkgutil.get_data returnsbytesin 3.NoneTypeis not available in 3urlparse_monkeypatchesin Python 2 only. Patches are not needed in 3 (tested in 3.2-3.4).